From f74b75fceffa7f150f9fde6ab91c4113da63ec65 Mon Sep 17 00:00:00 2001 From: MARCROCK22 Date: Tue, 29 Apr 2025 08:30:01 -0400 Subject: [PATCH] fix: change return types from 'never' to 'undefined' for various API methods --- src/common/shorters/interaction.ts | 5 +++-- src/types/rest/application.ts | 2 +- src/types/rest/autoModeration.ts | 2 +- src/types/rest/channel.ts | 28 +++++++++++++-------------- src/types/rest/emoji.ts | 2 +- src/types/rest/guild.ts | 22 ++++++++++----------- src/types/rest/guildScheduledEvent.ts | 2 +- src/types/rest/monetization.ts | 4 ++-- src/types/rest/soundboard.ts | 2 +- src/types/rest/stageInstance.ts | 2 +- src/types/rest/sticker.ts | 2 +- src/types/rest/user.ts | 2 +- src/types/rest/webhook.ts | 12 ++++++------ 13 files changed, 44 insertions(+), 43 deletions(-) diff --git a/src/common/shorters/interaction.ts b/src/common/shorters/interaction.ts index 76bf081..31ea314 100644 --- a/src/common/shorters/interaction.ts +++ b/src/common/shorters/interaction.ts @@ -1,5 +1,6 @@ import { BaseInteraction, Modal, type ReplyInteractionBody, resolveFiles } from '../..'; import { Transformers, type WebhookMessageStructure } from '../../client/transformers'; +import type { RESTPostAPIWebhookWithTokenWaitResult } from '../../types'; import type { InteractionMessageUpdateBodyRequest, MessageWebhookCreateBodyRequest } from '../types/write'; import { BaseShorter } from './base'; @@ -69,12 +70,12 @@ export class InteractionShorter extends BaseShorter { async followup(token: string, { files, ...body }: MessageWebhookCreateBodyRequest): Promise { const parsedFiles = files ? await resolveFiles(files) : undefined; - const apiMessage = await this.client.proxy + const apiMessage = (await this.client.proxy .webhooks(this.client.applicationId)(token) .post({ body: BaseInteraction.transformBody(body, parsedFiles, this.client), files: parsedFiles, - }); + })) as RESTPostAPIWebhookWithTokenWaitResult; return Transformers.WebhookMessage(this.client, apiMessage, this.client.applicationId, token); } } diff --git a/src/types/rest/application.ts b/src/types/rest/application.ts index e3b1957..377af4f 100644 --- a/src/types/rest/application.ts +++ b/src/types/rest/application.ts @@ -85,7 +85,7 @@ export type RESTPatchAPIApplicationEmojiResult = APIApplicationEmoji; /** * https://discord.com/developers/docs/resources/emoji#delete-application-emoji */ -export type RESTDeleteAPIApplicationEmojiResult = never; +export type RESTDeleteAPIApplicationEmojiResult = undefined; /** * https://discord.com/developers/docs/resources/application#get-application-activity-instance diff --git a/src/types/rest/autoModeration.ts b/src/types/rest/autoModeration.ts index e81ee1c..5c338b8 100644 --- a/src/types/rest/autoModeration.ts +++ b/src/types/rest/autoModeration.ts @@ -80,4 +80,4 @@ export type RESTPatchAPIAutoModerationRuleResult = APIAutoModerationRule; /** * https://discord.com/developers/docs/resources/auto-moderation#delete-auto-moderation-rule */ -export type RESTDeleteAPIAutoModerationRuleResult = never; +export type RESTDeleteAPIAutoModerationRuleResult = undefined; diff --git a/src/types/rest/channel.ts b/src/types/rest/channel.ts index 3a03fe8..87ac209 100644 --- a/src/types/rest/channel.ts +++ b/src/types/rest/channel.ts @@ -344,17 +344,17 @@ export type RESTPostAPIChannelMessageCrosspostResult = APIMessage; /** * https://discord.com/developers/docs/resources/channel#create-reaction */ -export type RESTPutAPIChannelMessageReactionResult = never; +export type RESTPutAPIChannelMessageReactionResult = undefined; /** * https://discord.com/developers/docs/resources/channel#delete-own-reaction */ -export type RESTDeleteAPIChannelMessageOwnReaction = never; +export type RESTDeleteAPIChannelMessageOwnReaction = undefined; /** * https://discord.com/developers/docs/resources/channel#delete-user-reaction */ -export type RESTDeleteAPIChannelMessageUserReactionResult = never; +export type RESTDeleteAPIChannelMessageUserReactionResult = undefined; /** * https://discord.com/developers/docs/resources/channel#get-reactions @@ -392,12 +392,12 @@ export type RESTGetAPIChannelMessageReactionUsersResult = APIUser[]; /** * https://discord.com/developers/docs/resources/channel#delete-all-reactions */ -export type RESTDeleteAPIChannelAllMessageReactionsResult = never; +export type RESTDeleteAPIChannelAllMessageReactionsResult = undefined; /** * https://discord.com/developers/docs/resources/channel#delete-all-reactions-for-emoji */ -export type RESTDeleteAPIChannelMessageReactionResult = never; +export type RESTDeleteAPIChannelMessageReactionResult = undefined; /** * https://discord.com/developers/docs/resources/channel#edit-message @@ -464,7 +464,7 @@ export type RESTPatchAPIChannelMessageResult = APIMessage; /** * https://discord.com/developers/docs/resources/channel#delete-message */ -export type RESTDeleteAPIChannelMessageResult = never; +export type RESTDeleteAPIChannelMessageResult = undefined; /** * https://discord.com/developers/docs/resources/channel#bulk-delete-messages @@ -479,7 +479,7 @@ export interface RESTPostAPIChannelMessagesBulkDeleteJSONBody { /** * https://discord.com/developers/docs/resources/channel#bulk-delete-messages */ -export type RESTPostAPIChannelMessagesBulkDeleteResult = never; +export type RESTPostAPIChannelMessagesBulkDeleteResult = undefined; /** * https://discord.com/developers/docs/resources/channel#edit-channel-permissions @@ -510,7 +510,7 @@ export interface RESTPutAPIChannelPermissionJSONBody { /** * https://discord.com/developers/docs/resources/channel#edit-channel-permissions */ -export type RESTPutAPIChannelPermissionResult = never; +export type RESTPutAPIChannelPermissionResult = undefined; /** * https://discord.com/developers/docs/resources/channel#get-channel-invites @@ -574,7 +574,7 @@ export type RESTPostAPIChannelInviteResult = APIExtendedInvite; /** * https://discord.com/developers/docs/resources/channel#delete-channel-permission */ -export type RESTDeleteAPIChannelPermissionResult = never; +export type RESTDeleteAPIChannelPermissionResult = undefined; /** * https://discord.com/developers/docs/resources/channel#follow-news-channel @@ -594,7 +594,7 @@ export type RESTPostAPIChannelFollowersResult = APIFollowedChannel; /** * https://discord.com/developers/docs/resources/channel#trigger-typing-indicator */ -export type RESTPostAPIChannelTypingResult = never; +export type RESTPostAPIChannelTypingResult = undefined; /** * https://discord.com/developers/docs/resources/channel#get-pinned-messages @@ -604,12 +604,12 @@ export type RESTGetAPIChannelPinsResult = APIMessage[]; /** * https://discord.com/developers/docs/resources/channel#pin-message */ -export type RESTPutAPIChannelPinResult = never; +export type RESTPutAPIChannelPinResult = undefined; /** * https://discord.com/developers/docs/resources/channel#unpin-message */ -export type RESTDeleteAPIChannelPinResult = never; +export type RESTDeleteAPIChannelPinResult = undefined; /** * https://discord.com/developers/docs/resources/channel#group-dm-add-recipient @@ -711,12 +711,12 @@ export type RESTPostAPIChannelThreadsResult = APIChannel; /** * https://discord.com/developers/docs/resources/channel#join-thread */ -export type RESTPutAPIChannelThreadMembersResult = never; +export type RESTPutAPIChannelThreadMembersResult = undefined; /** * https://discord.com/developers/docs/resources/channel#leave-thread */ -export type RESTDeleteAPIChannelThreadMembersResult = never; +export type RESTDeleteAPIChannelThreadMembersResult = undefined; /** * https://discord.com/developers/docs/resources/channel#get-thread-member diff --git a/src/types/rest/emoji.ts b/src/types/rest/emoji.ts index c398430..9fdddd4 100644 --- a/src/types/rest/emoji.ts +++ b/src/types/rest/emoji.ts @@ -58,4 +58,4 @@ export type RESTPatchAPIGuildEmojiResult = APIEmoji; /** * https://discord.com/developers/docs/resources/emoji#delete-guild-emoji */ -export type RESTDeleteAPIGuildEmojiResult = never; +export type RESTDeleteAPIGuildEmojiResult = undefined; diff --git a/src/types/rest/guild.ts b/src/types/rest/guild.ts index 134e197..8185054 100644 --- a/src/types/rest/guild.ts +++ b/src/types/rest/guild.ts @@ -322,7 +322,7 @@ export type RESTPatchAPIGuildResult = APIGuild; /** * https://discord.com/developers/docs/resources/guild#delete-guild */ -export type RESTDeleteAPIGuildResult = never; +export type RESTDeleteAPIGuildResult = undefined; /** * https://discord.com/developers/docs/resources/guild#get-guild-channels @@ -364,7 +364,7 @@ export type RESTPatchAPIGuildChannelPositionsJSONBody = { /** * https://discord.com/developers/docs/resources/guild#modify-guild-channel-positions */ -export type RESTPatchAPIGuildChannelPositionsResult = never; +export type RESTPatchAPIGuildChannelPositionsResult = undefined; /** * https://discord.com/developers/docs/resources/guild#list-active-guild-threads @@ -513,17 +513,17 @@ export interface RESTPatchAPICurrentGuildMemberJSONBody { /** * https://discord.com/developers/docs/resources/guild#add-guild-member-role */ -export type RESTPutAPIGuildMemberRoleResult = never; +export type RESTPutAPIGuildMemberRoleResult = undefined; /** * https://discord.com/developers/docs/resources/guild#remove-guild-member-role */ -export type RESTDeleteAPIGuildMemberRoleResult = never; +export type RESTDeleteAPIGuildMemberRoleResult = undefined; /** * https://discord.com/developers/docs/resources/guild#remove-guild-member */ -export type RESTDeleteAPIGuildMemberResult = never; +export type RESTDeleteAPIGuildMemberResult = undefined; /** * https://discord.com/developers/docs/resources/guild#get-guild-bans @@ -568,12 +568,12 @@ export interface RESTPutAPIGuildBanJSONBody { /** * https://discord.com/developers/docs/resources/guild#create-guild-ban */ -export type RESTPutAPIGuildBanResult = never; +export type RESTPutAPIGuildBanResult = undefined; /** * https://discord.com/developers/docs/resources/guild#remove-guild-ban */ -export type RESTDeleteAPIGuildBanResult = never; +export type RESTDeleteAPIGuildBanResult = undefined; /** * https://discord.com/developers/docs/resources/guild#bulk-guild-ban @@ -723,7 +723,7 @@ export type RESTPatchAPIGuildRoleResult = APIRole; /** * https://discord.com/developers/docs/resources/guild#delete-guild-role */ -export type RESTDeleteAPIGuildRoleResult = never; +export type RESTDeleteAPIGuildRoleResult = undefined; /** * https://discord.com/developers/docs/resources/guild#get-guild-prune-count @@ -800,7 +800,7 @@ export type RESTGetAPIGuildIntegrationsResult = APIGuildIntegration[]; /** * https://discord.com/developers/docs/resources/guild#delete-guild-integration */ -export type RESTDeleteAPIGuildIntegrationResult = never; +export type RESTDeleteAPIGuildIntegrationResult = undefined; /** * https://discord.com/developers/docs/resources/guild#get-guild-widget-settings @@ -888,7 +888,7 @@ export interface RESTPatchAPIGuildVoiceStateCurrentMemberJSONBody { /** * https://discord.com/developers/docs/resources/guild#modify-current-user-voice-state */ -export type RESTPatchAPIGuildVoiceStateCurrentMemberResult = never; +export type RESTPatchAPIGuildVoiceStateCurrentMemberResult = undefined; /** * https://discord.com/developers/docs/resources/guild#modify-user-voice-state @@ -907,7 +907,7 @@ export interface RESTPatchAPIGuildVoiceStateUserJSONBody { /** * https://discord.com/developers/docs/resources/guild#modify-user-voice-state */ -export type RESTPatchAPIGuildVoiceStateUserResult = never; +export type RESTPatchAPIGuildVoiceStateUserResult = undefined; /** * https://discord.com/developers/docs/resources/guild#get-guild-welcome-screen diff --git a/src/types/rest/guildScheduledEvent.ts b/src/types/rest/guildScheduledEvent.ts index d57a810..13aa943 100644 --- a/src/types/rest/guildScheduledEvent.ts +++ b/src/types/rest/guildScheduledEvent.ts @@ -106,7 +106,7 @@ export type RESTPatchAPIGuildScheduledEventResult = APIGuildScheduledEvent; /** * https://discord.com/developers/docs/resources/guild-scheduled-event#delete-guild-scheduled-event */ -export type RESTDeleteAPIGuildScheduledEventResult = never; +export type RESTDeleteAPIGuildScheduledEventResult = undefined; /** * https://discord.com/developers/docs/resources/guild-scheduled-event#get-guild-scheduled-event-users diff --git a/src/types/rest/monetization.ts b/src/types/rest/monetization.ts index 71b5e21..47a21d0 100644 --- a/src/types/rest/monetization.ts +++ b/src/types/rest/monetization.ts @@ -86,7 +86,7 @@ export enum EntitlementOwnerType { /** * https://discord.com/developers/docs/monetization/entitlements#delete-test-entitlement */ -export type RESTDeleteAPIEntitlementResult = never; +export type RESTDeleteAPIEntitlementResult = undefined; /** * https://discord.com/developers/docs/monetization/skus#list-skus @@ -96,7 +96,7 @@ export type RESTGetAPISKUsResult = APISKU[]; /** * https://discord.com/developers/docs/monetization/entitlements#consume-an-entitlement */ -export type RESTPostAPIEntitlementConsumeResult = never; +export type RESTPostAPIEntitlementConsumeResult = undefined; /** * https://canary.discord.com/developers/docs/resources/subscription#query-string-params diff --git a/src/types/rest/soundboard.ts b/src/types/rest/soundboard.ts index 7be6595..26d9534 100644 --- a/src/types/rest/soundboard.ts +++ b/src/types/rest/soundboard.ts @@ -67,4 +67,4 @@ export type RESTPatchAPIGuildSoundboardSoundResult = APISoundBoard; * This endpoint supports the X-Audit-Log-Reason header. * @fires GuildSoundboardSoundDelete */ -export type RESTDeleteAPIGuildSoundboardSoundResult = never; +export type RESTDeleteAPIGuildSoundboardSoundResult = undefined; diff --git a/src/types/rest/stageInstance.ts b/src/types/rest/stageInstance.ts index 0b8e13f..fab14ef 100644 --- a/src/types/rest/stageInstance.ts +++ b/src/types/rest/stageInstance.ts @@ -61,4 +61,4 @@ export type RESTPatchAPIStageInstanceResult = APIStageInstance; /** * https://discord.com/developers/docs/resources/stage-instance#delete-stage-instance */ -export type RESTDeleteAPIStageInstanceResult = never; +export type RESTDeleteAPIStageInstanceResult = undefined; diff --git a/src/types/rest/sticker.ts b/src/types/rest/sticker.ts index f7e87c4..392ef23 100644 --- a/src/types/rest/sticker.ts +++ b/src/types/rest/sticker.ts @@ -82,4 +82,4 @@ export type RESTPatchAPIGuildStickerResult = APISticker; /** * https://discord.com/developers/docs/resources/sticker#delete-guild-sticker */ -export type RESTDeleteAPIGuildStickerResult = never; +export type RESTDeleteAPIGuildStickerResult = undefined; diff --git a/src/types/rest/user.ts b/src/types/rest/user.ts index 1ec8906..35b8b17 100644 --- a/src/types/rest/user.ts +++ b/src/types/rest/user.ts @@ -91,7 +91,7 @@ export type RESTGetAPICurrentUserGuildsResult = RESTAPIPartialCurrentUserGuild[] /** * https://discord.com/developers/docs/resources/user#leave-guild */ -export type RESTDeleteAPICurrentUserGuildResult = never; +export type RESTDeleteAPICurrentUserGuildResult = undefined; /** * https://discord.com/developers/docs/resources/user#create-dm diff --git a/src/types/rest/webhook.ts b/src/types/rest/webhook.ts index 7ce987a..1b97e55 100644 --- a/src/types/rest/webhook.ts +++ b/src/types/rest/webhook.ts @@ -89,12 +89,12 @@ export type RESTPatchAPIWebhookWithTokenResult = RESTGetAPIWebhookWithTokenResul /** * https://discord.com/developers/docs/resources/webhook#delete-webhook */ -export type RESTDeleteAPIWebhookResult = never; +export type RESTDeleteAPIWebhookResult = undefined; /** * https://discord.com/developers/docs/resources/webhook#delete-webhook-with-token */ -export type RESTDeleteAPIWebhookWithTokenResult = never; +export type RESTDeleteAPIWebhookWithTokenResult = undefined; /** * https://discord.com/developers/docs/resources/webhook#execute-webhook @@ -202,7 +202,7 @@ export interface RESTPostAPIWebhookWithTokenQuery { /** * https://discord.com/developers/docs/resources/webhook#execute-webhook */ -export type RESTPostAPIWebhookWithTokenResult = never; +export type RESTPostAPIWebhookWithTokenResult = undefined; /** * Received when a call to https://discord.com/developers/docs/resources/webhook#execute-webhook receives @@ -220,7 +220,7 @@ export type RESTPostAPIWebhookWithTokenSlackQuery = Omit