yuzucchii/jetzig
1
0
Fork 0
mirror of https://github.com/jetzig-framework/jetzig.git synced 2025-05-14 22:16:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Headers.getFirstValue

Browse Source 
Bugfix to resolve issue with undefined behaviour when calling
`getFirstValue` - first header would always be returned. Add regression
test.
This commit is contained in:
Bob Farrell 2024-03-17 10:26:10 +00:00
parent b61700cff6
commit 3c47dff96e
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/jetzig/http/Headers.zig
View File

@ -20,10 +20,10 @@ pub fn deinit(self: *Self) void {
// Gets the first value for a given header identified by `name`. Case-insensitive string comparison.
pub fn getFirstValue(self: *Self, name: []const u8) ?[]const u8 {
for (self.headers.items) |header| {
headers: for (self.headers.items) |header| {
if (name.len != header.name.len) continue;
for (name, header.name) |expected, actual| {
if (std.ascii.toLower(expected) != std.ascii.toLower(actual)) continue;
if (std.ascii.toLower(expected) != std.ascii.toLower(actual)) continue :headers;
}
return header.value;
}
@ -82,6 +82,15 @@ test "append" {
try std.testing.expectEqualStrings(headers.getFirstValue("foo").?, "bar");
}
test "getFirstValue with multiple headers (bugfix regression test)" {
const allocator = std.testing.allocator;
var headers = Self.init(allocator);
defer headers.deinit();
try headers.append("foo", "bar");
try headers.append("bar", "baz");
try std.testing.expectEqualStrings(headers.getFirstValue("bar").?, "baz");
}
test "case-insensitive matching" {
const allocator = std.testing.allocator;
var headers = Self.init(allocator);