From d0b69200b99f0d7fa8169bf664c72b4d6bb608ff Mon Sep 17 00:00:00 2001 From: axispx Date: Tue, 26 Mar 2024 13:31:50 +0545 Subject: [PATCH] Fix CI silent failure bug CI failed silently during "Build artifacts" stage when build failed in the bash for loop causing the overall job to be successful even when it wasn't. --- .github/workflows/CI.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0567d18..e045110 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -52,7 +52,9 @@ jobs: for target in "${targets[@]}"; do mkdir -p $root/artifacts/$target echo "Building target ${target}..." - zig build -Dtarget=${target} -Doptimize=ReleaseSafe --prefix $root/artifacts/${target}/ & + if ! zig build -Dtarget=${target} -Doptimize=ReleaseSafe --prefix $root/artifacts/${target}/; then + exit 1 + fi sed -e '1,5d' < $root/README.md > $root/artifacts/${target}/README.md cp $root/LICENSE $root/artifacts/${target}/ done