yuzucchii/discord.zig
2
3
Fork 2
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix return type being RequestFailedError!void instead of RequestFailedError!Result(Types.Message) #2

Merged
yuzucchii merged 1 commits from MjutBut/discord.zig:bugfix into master 2025-06-06 23:49:07 +00:00
Conversation 3 Commits 1 Files Changed 1 +1 -2
MjutBut commented 2025-06-05 21:45:06 +00:00
Contributor
Copy Link
No description provided.
MjutBut added 1 commit 2025-06-05 21:45:06 +00:00
yuzucchii commented 2025-06-06 18:38:29 +00:00
Owner
Copy Link

that's not how the API works
https://discord.com/developers/docs/resources/message#delete-message

204 empty response on success

that's not how the API works https://discord.com/developers/docs/resources/message#delete-message > 204 empty response on success
yuzucchii closed this pull request 2025-06-06 18:38:29 +00:00
MjutBut commented 2025-06-06 22:12:40 +00:00
Author
Contributor
Copy Link

that's not how the API works
https://discord.com/developers/docs/resources/message#delete-message

204 empty response on success

It’s a CreateMessage (sendMessageWithFiles()) tho, no? I apologize if I’m being wrong here

I think my editor has removed a whitespace on line 2071 hence the confusion, the actual changes are on line 135

> that's not how the API works > https://discord.com/developers/docs/resources/message#delete-message > > 204 empty response on success It’s a CreateMessage (sendMessageWithFiles()) tho, no? I apologize if I’m being wrong here I think my editor has removed a whitespace on line 2071 hence the confusion, the actual changes are on line 135
MjutBut reopened this pull request 2025-06-06 22:18:18 +00:00
yuzucchii commented 2025-06-06 23:49:00 +00:00
Owner
Copy Link

oh yeah my bad, thanks for the pull request

oh yeah my bad, thanks for the pull request
yuzucchii merged commit edd113abf7 into master 2025-06-06 23:49:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yuzucchii
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yuzucchii/discord.zig#2
No description provided.
Delete Branch "MjutBut/discord.zig:bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?